Handle double faced cards and flipped card #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So when I was testing this on the server i thought it was working, but when i scrolled over a flipped card it crashed the program. I built it locally but don't have the flipping mech on scroll over, so not sure what's up. |
|
Update: Works as expected. Heroku is being taxed too much |
|
This is awesome, thank you @HerveH44 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
I rechechecked how MTGJson v4 indicates special cards and modified how to catch double faced cards.
Closes #77
I didn't handle aftermath cards because I'm really not sure how to handle them (the rotate 90° and crop half the card is not convincing enough IMO)