Fix Terminal Background Color

[apierz]

When using Dracula theme in terminal the result is a blue background that does not look good:

By setting the background color to nil when emacs is run in the terminal, the normal color of the terminal background will be used. If the user is using Dracula theme colors in their terminal the proper color will show:

[bentruyman]

Can we get this merged in? This is driving me nuts!

[film42]

@bentruyman I'll merge it in tomorrow morning! Spent last week sick so I've had lots of catching up to do this week. Thanks for keeping me on my toes :).

[film42]

It's in! Released as 1.3.0! 🎉 🌮 🥇

[bentruyman]

@film42 I'm sorry to hear that. Hope you're feeling better!

One thing I did notice, in the terminal the line highlight color is purple and regions (e.g. visual selections) have the correct yellow background but no foreground.

I've made these adjustments in my own emacs configuration:

(unless (display-graphic-p)
  (progn
    (set-face-background 'hl-line "#333333")
    (set-face-attribute 'region nil :foreground "#000000")
    ))

Here's what it looks like currently:

Here's with the adjustments:

EDIT: Looks like you've released while I was making this comment! I can create a new issue to discuss the above changes I'm trying. However, I honestly don't know if this is a correct change or how one would best go about making it.

[benreyn]

@bentruyman, based on the changes you made, it seems like we might want to start discussing a bit of the architecture of this theme and possibly running to different chunks of variable assigning code to make sure the theme looks right in both a terminal, and a graphical version of emacs.

[bentruyman]

@benjamreynolds I think I would agree. I'm relatively new to emacs and even more so with theming. But it does seem like having two branches in the theme (one for GUIs and one for terminal) to provide different color options based on your current capabilities until Emacs lands 24-bit/True Color support would be a good idea.

[benreyn]

i was actually just looking at some of the more mature emacs themes and how some of the implementation is done. We may consider working on some bigger refactors of this theme that may solve some of these issues. I'll create and issue to start the discussion.

[film42]

@benjamreynolds @bentruyman I would love to see that happen!