Add "Properties" section to select dark theme #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-detects dark theme on websites Sets style for settings pages https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#properties
|
works fine for me, but you should bump the version number when you change the manifest.json file cause otherwise I won't be able to update the theme on the addons store (tho I could do that myself) |
|
Fixed. I was unsure of the "versioning scheme" used here. |
|
All set. |
|
@RaphGL |
|
yes it will, I will be shipping it soon, I just got a little busy lately |
|
Version with the changes has been shipped and is waiting for approval by Firefox. An XPI of the theme is also available here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the "properties" section to the theme.
This allows for the following:
Documentation:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme#properties