Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix default dashboard dock styles #208

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ran-dall
Copy link
Contributor

@ran-dall ran-dall commented Aug 8, 2022

Please Don't ship WIP

Fixes: #207

Some of our stylings no longer work on GNOME 42.3.1 (may have broken before, but I just noticed it), and are causing the problems seen in #207.

This PR resets the Dock Styling to default (as that is what upstream seems to want) and also fixes compatibility problems with Blur-My-Shell.

@ran-dall
Copy link
Contributor Author

ran-dall commented Aug 8, 2022

@EliverLara, I've commented out the offending code in gnome-shell.css so you can see what code was causing the problem. The code I commented out starts on line 1650.

I didn't modify the .scss yet because I wanted to know what you wanted to do about this. Not all the code is offending, but our background-colors styling (for one) isn't being respected anymore. That said, though, after reviewing the GNOME team, it would seem that a few things need to be rethought. According to the GNOME team (at least the ones on there today on Matrix), we should now generally stay away from hard-lining colors, fonts, etc., when LibAdwaita is already handing them in instances like that Dashboard.

So I dunno if I should just remove them or just remove the offending code? It seems like the styling we can do in the Dashboard right now is an easter egg, as there are no guarantees about what may or may not work in the future. I've also been told that extension use will continue to be a problem, as many extensions already work with LibAdwaita, and our styles will clash with them (i.e. Dash-to-Dock and Blur-My-Shell).

Let me know, and I'll make the changes to the .sass files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Broken styles on Dashboard Dock
1 participant