Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix height of button on SDDM login #241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RobTheFiveNine
Copy link

This change fixes an issue with the SDDM login screen. The background of the button was set to an absolute height of 30, but the element itself was taller. As a result, there is an unequal amount of spacing between the top of the button and the bottom of the button, as can be seen in this screenshot prior to the final change (ignore that the button is max width, that was just me testing):

image

I have changed the background to instead match the height of the parent element, which results in the text being correctly vertically aligned in the center of the button:

image

Apologies for the camera shots instead of screenshots, I didn't have a VM to make the changes in, I did it on my host machine

@RobTheFiveNine
Copy link
Author

@EliverLara could you take a look at this and #242 ? Would be good to get this one in particular merged in to fix this issue in the main distribution channel for KDE users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant