Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: introduce a 'ib-pkey=' command line argument #1538

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

bengal
Copy link
Contributor

@bengal bengal commented Jun 16, 2021

An Infiniband network can be segmented in different partitions, similar to VLANs. Each partition is identified by a partition key (P_Key).

On Linux, a new partition for a IP-over-Infiniband device can be created via e.g.:

echo 0x8001 > /sys/class/net/ib0/create_child

The resulting interface will be ib0.8001 with P_Key 0x8001.

Document a new command line argument to create the partition.

NetworkManager is going to implement the new option in [1].

[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/884

@johannbg
Copy link
Collaborator

@bengal Hmm aren't we missing what actually parses that command line argument ( from the nm module? ) in this PR?
Is this still an WIP?

@tyll
Copy link
Contributor

tyll commented Jun 18, 2021

@bengal Hmm aren't we missing what actually parses that command line argument ( from the nm module? ) in this PR?
Is this still an WIP?

The NetworkManager part is here: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/884

@bengal
Copy link
Contributor Author

bengal commented Jun 21, 2021

@bengal Hmm aren't we missing what actually parses that command line argument ( from the nm module? )

Right, this PR only adds documentation for the new command line argument.

For the network-manager module, the new argument doesn't need to be implemented in the dracut repo but in NM itself. There is already a PR ready to be merged, as soon as this gets accepted. Perhaps the man page should document the NM version in which the feature is added?

@tyll
Copy link
Contributor

tyll commented Jun 23, 2021

@johannbg in case it is not clear: The NM implementation is blocked by getting approval for the naming of the command line argument requested here. Therefore it would be great to some feedback whether the name is fine or not. Thank you.

@johannbg
Copy link
Collaborator

@tyll well I think the tradition would be to have it ib.pkey= also note the decided command line argument might need to be excluded from systemd's network generator but I leave it up to @haraldh to ack or nack the command line argument as is, he however is on vacation and will return I think next week so this is stuck until he's back.

@johannbg
Copy link
Collaborator

@haraldh ping since you seem to be back from vacation 😄

@haraldh
Copy link
Collaborator

haraldh commented Jul 1, 2021

Shall we document kernel command line options, which dracut does not parse in any way?

A better way is to mention additional man pages, where useful kernel command line options are documented.

@haraldh
Copy link
Collaborator

haraldh commented Jul 1, 2021

This way, the dracut documentation is rarely out of sync.

@tyll
Copy link
Contributor

tyll commented Jul 2, 2021

So if we implement this as ib.pkey it would be fine by you? We can document this at our end, too. It would be great if we can get some go ahead for this so we can merge the implementation for NM.

@bengal
Copy link
Contributor Author

bengal commented Jul 8, 2021

A better way is to mention additional man pages, where useful kernel command line options are documented.

@haraldh @johannbg , what do you think about the new commit? My only concern with this approach is that it could cause more incompatibility, with different modules implementing different options (or the same option with different names).

Another question: is it better to namespace new options with the rd. prefix (e.g. rd.ib.pkey) or is something like ib.pkey fine? Existing virtual devices like bridge, bond, vlan, etc. don't have the prefix and so probably ib.pkey shouldn't have it either.

@johannbg
Copy link
Collaborator

johannbg commented Jul 8, 2021

@bengal yeah it will end up causing more confusion and incompatibility regarding the rd. prefix @haraldh is more familiar with existing naming conventions but I would say just keep it ib.pkey

thom311 pushed a commit to NetworkManager/NetworkManager that referenced this pull request Jul 26, 2021
Introduce a new "ib.pkey=<parent>.<pkey>" command line argument to
create a Infiniband partition.

The new connection has IPv4 and IPv6 enabled by default. Unlike for
VLANs, the generator doesn't create a connection for the parent
Infiniband interface.

See also: dracutdevs/dracut#1538

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/884
thom311 pushed a commit to NetworkManager/NetworkManager that referenced this pull request Jul 27, 2021
Introduce a new "ib.pkey=<parent>.<pkey>" command line argument to
create a Infiniband partition.

The new connection has IPv4 and IPv6 enabled by default. Unlike for
VLANs, the generator doesn't create a connection for the parent
Infiniband interface.

See also: dracutdevs/dracut#1538

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/884
(cherry picked from commit 9060c14)
@haraldh haraldh merged commit c868feb into dracutdevs:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants