-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(overlayfs): allow hostonly and nfs support #2269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to fix the shfmt
format:
https://github.com/dracutdevs/dracut/actions/runs/4350868266/jobs/7601984774?pr=2269
The "allow hostonly" part is ok, but it has nothing to do with "Execute mount-overlayfs later in the boot process as well.". You should split that into another commit and give the proper reason for that (why does not it work as expected?).
769b60e
to
9a2d04c
Compare
Thank you for all the reviews @aafeijoo-suse . Without your reviews the project would be stalled.
Sorry I missed it.
Split the changes into two commit.
I improved the test case to test for this scenario, so now everybody can reproduce and understand the failure and also this test case would guard for future regression of this use-case. |
9a2d04c
to
3a285c2
Compare
3106563
to
5bcd844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved the test case to test for this scenario, so now everybody can reproduce and understand the failure and also this test case would guard for future regression of this use-case.
Ok, thanks!
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Check for overlay kernel module support.
Execute mount-overlayfs later in the boot process as a pre-pivot hook. The existing mount hook is skipped for network boot. Without this change `dracut -a "overlayfs nfs"` would not work as expected. Improved the existing test case to test for this scenario.
5bcd844
to
51f1211
Compare
Check for overlay kernel module support.
Execute mount-overlayfs later in the boot process. Without this change
dracut -a "overlayfs nfs"
does not work as expected.Checklist
Fixes #