Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlayfs): allow hostonly and nfs support #2269

Closed
wants to merge 2 commits into from

Conversation

LaszloGombos
Copy link
Collaborator

@LaszloGombos LaszloGombos commented Mar 7, 2023

Check for overlay kernel module support.

Execute mount-overlayfs later in the boot process. Without this change dracut -a "overlayfs nfs" does not work as expected.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix the shfmt format:

https://github.com/dracutdevs/dracut/actions/runs/4350868266/jobs/7601984774?pr=2269

The "allow hostonly" part is ok, but it has nothing to do with "Execute mount-overlayfs later in the boot process as well.". You should split that into another commit and give the proper reason for that (why does not it work as expected?).

@github-actions github-actions bot added the test Issues related to testing label Mar 30, 2023
@LaszloGombos
Copy link
Collaborator Author

LaszloGombos commented Mar 30, 2023

Thank you for all the reviews @aafeijoo-suse . Without your reviews the project would be stalled.

You need to fix the shfmt format:

Sorry I missed it.

The "allow hostonly" part is ok, but it has nothing to do with "Execute mount-overlayfs later in the boot process as well.". > You should split that into another commit and give the proper reason for that (why does not it work as expected?).

Split the changes into two commit.

give the proper reason for that (why does not it work as expected?).

I improved the test case to test for this scenario, so now everybody can reproduce and understand the failure and also this test case would guard for future regression of this use-case.

@LaszloGombos LaszloGombos changed the title fix(overlayfs): allow hostonly fix(overlayfs): allow hostonly and nfs support Mar 30, 2023
@LaszloGombos LaszloGombos force-pushed the overlaynfs branch 2 times, most recently from 3106563 to 5bcd844 Compare March 30, 2023 16:26
Copy link
Member

@aafeijoo-suse aafeijoo-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the test case to test for this scenario, so now everybody can reproduce and understand the failure and also this test case would guard for future regression of this use-case.

Ok, thanks!

@stale
Copy link

stale bot commented Sep 16, 2023

This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions.

@stale stale bot added the stale communication is stuck label Sep 16, 2023
@aafeijoo-suse aafeijoo-suse removed the stale communication is stuck label Sep 18, 2023
@LaszloGombos LaszloGombos reopened this Oct 31, 2023
Check for overlay kernel module support.
Execute mount-overlayfs later in the boot process as a pre-pivot
hook. The existing mount hook is skipped for network boot.

Without this change
`dracut  -a "overlayfs nfs"`
would not work as expected.

Improved the existing test case to test for this scenario.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issue tracker for all modules overlayfs test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants