Support for wicked network manager

[danimo]

This introduces support for wicked as network management module.

Todo:

• compare dbus module with the one in the bluetooth HiD PR.
• add tests if possible (wicked is probably not available on fedora)
• check if all parameters are properly accepted
• add documentation

[danimo]

Effective diff between the wicked (a) and the bluetooth dbus module (b):

diff --git a/modules.d/06dbus/module-setup.sh b/modules.d/06dbus/module-setup.sh
old mode 100755
new mode 100644
index 6843cfa3..0e8262c7
--- a/modules.d/06dbus/module-setup.sh
+++ b/modules.d/06dbus/module-setup.sh
@@ -36,30 +36,16 @@ install() {
     /usr/bin/dbus-daemon \
     /usr/bin/dbus-send
 
-  dbus_system_services="
-        org.freedesktop.systemd1
-        org.freedesktop.timedate1
-        org.freedesktop.hostname1
-  "
-  inst_dir      /etc/dbus-1/system.d
-  inst_dir      /usr/share/dbus-1/services
-  inst_dir      /usr/share/dbus-1/system-services
-  inst_multiple /etc/dbus-1/system.conf
-  inst_multiple /usr/share/dbus-1/system.conf \
-                /usr/share/dbus-1/services/org.freedesktop.systemd1.service
-  for service in $dbus_system_services ; do
-      inst_multiple        /etc/dbus-1/system.d/${service}.conf \
-              /usr/share/dbus-1/system-services/${service}.service
-  done
+  inst_multiple $(find /usr/share/dbus-1)
+  inst_multiple $(find /etc/dbus-1)
   inst_multiple $(find /var/lib/dbus)
 
   inst_hook cleanup 99 "$moddir/dbus-cleanup.sh"
 
-  grep '^messagebus:' /etc/passwd >> "$initdir/etc/passwd"
-  grep '^messagebus:' /etc/group >> "$initdir/etc/group"
+  grep '^dbus:' /etc/passwd >> "$initdir/etc/passwd"
+  grep '^dbus:' /etc/group >> "$initdir/etc/group"
 
-  # do not enable -- this is a static service
-  #systemctl --root "$initdir" enable $DBUS_SERVICE > /dev/null 2>&1
+  systemctl --root "$initdir" enable $DBUS_SERVICE > /dev/null 2>&1
 
   sed -i -e \
 '/^\[Unit\]/aDefaultDependencies=no\

• inst_multiple chained with find seems crude, need to revisit why this was done
• not sure about why the network services would be needed, why install them?
• dbus vs. messagebus user is a distro thing, can be unified via grep -E '^(d|message)bus:' /etc/passwd

[rtorrero]

About your first point:

$ find /var/lib/dbus
/var/lib/dbus
/var/lib/dbus/machine-id

Maybe we could just add them explicitely, since it's just two files?

About the second point:

Do you mean the systemd service files for the wickedd parts? it's less messy to start it like this vs explicit calls since there are dependencies between the multiple wicked components and also due to the dependency with dbus. We tried multiple combinations and we had trouble to get get wicked started only when dbus was ready to be used. This way it seemed it worked fine.

[danimo]

$ find /var/lib/dbus
/var/lib/dbus
/var/lib/dbus/machine-id

Maybe we could just add them explicitely, since it's just two files?

Yes. If there is no deeper reason behind that, we should go for it. Also, we need to ensure the module either becomes host only safe.

About the second point:

Do you mean the systemd service files for the wickedd parts? it's less messy to start it like this vs explicit calls since there are dependencies between the multiple wicked components and also due to the dependency with dbus. We tried multiple combinations and we had trouble to get get wicked started only when dbus was ready to be used. This way it seemed it worked fine.

I was referring to this:

-  dbus_system_services="
-        org.freedesktop.systemd1
-        org.freedesktop.timedate1
-        org.freedesktop.hostname1
-  "

[danimo]

@rtorrero ping?

[rtorrero]

@rtorrero ping?

I'm currently recovering the setup I used to test this. I think I remember it had something to do with the resulting lease file in case of DHCP (that will be used after the initrd stage too).

[rtorrero]

@rtorrero ping?

I'm currently recovering the setup I used to test this. I think I remember it had something to do with the resulting lease file in case of DHCP (that will be used after the initrd stage too).

After doing some tests, I can confirm that

       org.freedesktop.systemd1
       org.freedesktop.timedate1
       org.freedesktop.hostname1
 "```
is not really needed. It made no difference having them there or not. 

[bengal]

Hi, any progress on this?

I'm reworking the NetworkManager dracut module to run as a systemd
service with D-Bus support and I'm looking forward to see the dbus
module in this pull request merged.

Maybe the dbus module could be a separate PR, so that it can be
reviewed and merged independently from wicked support?

[danimo]

@bengal Sorry for the slow progress. I've done some testing, addressed (most of) your concerns and will be doing some more testing tomorrow, before merging this.

[LaszloGombos]

Follow-up to try to test this module - #2117