Open Working Directory Menu Option #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates an option in 'File' in the launcher and project to 'Open Backup Directory', which opens the Temp directory.
LukePowell
reviewed
Jul 25, 2019
| menuHash['File'].push({ | ||
| label: 'Open Backup Directory', | ||
| click() { | ||
| switch (process.platform) { |
There was a problem hiding this comment.
No reason for this to be windows only.
There was a problem hiding this comment.
Oh, duh. This was left over from a thought process that the location would be OS specific, but clearly it's already dynamic based on where the project is located.
LukePowell
reviewed
Jul 25, 2019
desktop/main_core.js
Outdated
| click() { | ||
| switch (process.platform) { | ||
| case 'win32': | ||
| shell.showItemInFolder(path.join(app.getPath('temp'), '\\Temp')); |
There was a problem hiding this comment.
Suggested change
| shell.showItemInFolder(path.join(app.getPath('temp'), '\\Temp')); | |
| shell.showItemInFolder(path.join(app.getPath('temp'), 'dragondrop')); |
Simplified and corrected the code according to the github comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates an option in 'File' in the launcher and project to 'Open Backup Directory', which opens the Temp directory.