Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masters override replica's ID #2734

Closed
chakaz opened this issue Mar 17, 2024 · 0 comments · Fixed by #2735
Closed

Masters override replica's ID #2734

chakaz opened this issue Mar 17, 2024 · 0 comments · Fixed by #2735
Labels
bug Something isn't working

Comments

@chakaz
Copy link
Collaborator

chakaz commented Mar 17, 2024

As seen in #2726, we currently only save 1 replica ID per master.
This is a bug, as there could be multiple replicas connected to a single master. In that case, today, we falsely send the latest connected replica id in CLUSTER NODES.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cluster): Save replica ID per replica dragonflydb/dragonfly
1 participant
@chakaz