tools: Hash defrag script #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Aug 21, 2023
tools/defrag_all_hashes.py
Outdated
| info_worker = asyncio.create_task(infofn()) | ||
|
|
||
| keys = [] | ||
| async for key in r.scan_iter("*", count=batch_size * 2, type="hash"): |
There was a problem hiding this comment.
there is nothing special for hashes here. I suggest making the type an optional argument and scan everything by default .
Also, let's rename the script to defrag_db.py
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
dranikpg
force-pushed
the
script-defrag-hashes
branch
from
18f3325
to
98c4a91
Compare
romange
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we don't loose it