fix: fix defrag stats #1740
Merged
fix: fix defrag stats #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
kostasrim
previously approved these changes
Aug 25, 2023
What is being done on other data structures? |
Nothing, this is a follow up on #1727 |
Co-authored-by: Kostas Kyrimis <kostaskyrim@gmail.com> Signed-off-by: Vladislav <vladislav.oleshko@gmail.com>
romange
reviewed
Aug 25, 2023
src/core/compact_object_test.cc
Outdated
| @@ -634,7 +634,7 @@ TEST_F(CompactObjectTest, DefragHash) { | |||
|
|
|||
| // Trigger re-allocation | |||
| cobj_.InitRobj(OBJ_HASH, kEncodingListPack, target_lp); | |||
| cobj_.DefragIfNeeded(0.8); | |||
| CHECK(cobj_.DefragIfNeeded(0.8)); | |||
Signed-off-by: Vladislav Oleshko <vlad@dragonflydb.io>
kostasrim
pushed a commit
that referenced
this pull request
Aug 29, 2023
* fix: fix defrag stats Signed-off-by: Vladislav <vladislav.oleshko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug from the hash defrag PR: Successful re-allocations are not reported back.
Should we count a hash re-allocation as one (currently doing so) or also count every internal re-allocation (each StringMap key, etc.) ?