add loadtest benchmarking program #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
loadtest
branch
2 times, most recently
from
4748f0c
to
09400e8
Compare
Signed-off-by: Roman Gershman <roman@dragonflydb.io>
chakaz
previously approved these changes
Feb 18, 2024
src/server/dfly_bench.cc
Outdated
| CHECK(absl::SimpleAtoi(ratio_str.first, &ratio_set_)); | ||
| CHECK(absl::SimpleAtoi(ratio_str.second, &ratio_get_)); | ||
| } else { | ||
| for (size_t pos = 0; (pos = command_.find("__key__", pos)) != string::npos; pos += 7) { |
There was a problem hiding this comment.
Nit
Suggested change
| for (size_t pos = 0; (pos = command_.find("__key__", pos)) != string::npos; pos += 7) { | |
| constexpr string_view kKeyPlaceholder = "__key__"sv; | |
| for (size_t pos = 0; (pos = command_.find(kKeyPlaceholder, pos)) != string::npos; pos += kKeyPlaceholder.size()) { |
There was a problem hiding this comment.
For my defense this code was written by copilot.
src/server/dfly_bench.cc
Outdated
| for (size_t pos : key_indices_) { | ||
| key = (*keygen_)(); | ||
| absl::StrAppend(&cmd_, command_.substr(last_pos, pos - last_pos), key); | ||
| last_pos = pos + 7; |
There was a problem hiding this comment.
see above
maybe make kKeyPlaceholder global
| socket_.reset(p->CreateSocket()); | ||
| } | ||
|
|
||
| Driver(const Driver&) = delete; |
There was a problem hiding this comment.
Nit: you could make this class movable (default should work: Driver(Driver&&) = default), which will allow you below to hold a vector<Driver> instead of using unique_ptrs
There was a problem hiding this comment.
do not know if it is better but done :)
lsvmello
pushed a commit
to lsvmello/dragonfly
that referenced
this pull request
Feb 19, 2024
* feat: add loadtest skeleton --------- Signed-off-by: Roman Gershman <roman@dragonflydb.io> Co-authored-by: shahar <shahar@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports only ratio param, without command customization.
Added Normal/Uniform distributions.
Improved printings a bit to make it more useful as a cli.