Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #633

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Update README.md #633

merged 3 commits into from
Jan 5, 2023

Conversation

yingshaoxo
Copy link
Contributor

add docker-compose example config

Signed-off-by: yingshaoxo yingshaoxo@gmail.com

add docker-compose example config

Signed-off-by: yingshaoxo <yingshaoxo@gmail.com>
@romange
Copy link
Collaborator

romange commented Jan 2, 2023

Thanks! Have you seen my comment about '--dir' flag?

README.md Outdated
image: docker.dragonflydb.io/dragonflydb/dragonfly
command:
- "--save_schedule=*:*" # save for every 1 minute
- "--dbfilename=/data/dump.rdb"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add --dir=/data argument

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need a full path when you pass --dir :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified.

add "--dir=/data" to docker-compose example

Signed-off-by: yingshaoxo <yingshaoxo@gmail.com>
Signed-off-by: yingshaoxo <yingshaoxo@gmail.com>
@romange romange merged commit 1895d31 into dragonflydb:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants