Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: make benchmark compare summary more clear #1251

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Desiki-high
Copy link
Member

Ref: #1250

To make the summary more clear.

@Desiki-high Desiki-high requested a review from a team as a code owner April 25, 2023 10:24
@Desiki-high Desiki-high requested review from bergwolf, jiangliu and luodw and removed request for a team April 25, 2023 10:24
@cr-gpt

This comment was marked as abuse.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #1251 (bfba44b) into master (44b70fa) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   45.02%   45.01%   -0.02%     
==========================================
  Files         126      126              
  Lines       37382    37382              
  Branches    37382    37382              
==========================================
- Hits        16832    16826       -6     
- Misses      19660    19669       +9     
+ Partials      890      887       -3     

see 4 files with indirect coverage changes

@cr-gpt

This comment was marked as abuse.

@cr-gpt

This comment was marked as abuse.

@cr-gpt

This comment was marked as abuse.

@cr-gpt

This comment was marked as abuse.

1 similar comment
@cr-gpt
Copy link

cr-gpt bot commented Apr 25, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables for this repo. you could follow readme for more information

@cr-gpt
Copy link

cr-gpt bot commented Apr 26, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@cr-gpt

This comment was marked as abuse.

@Desiki-high Desiki-high linked an issue Apr 26, 2023 that may be closed by this pull request
@Desiki-high Desiki-high changed the title [WIP]action: make benchmark compare summary more clear action: make benchmark compare summary more clear Apr 26, 2023
@anolis-bot
Copy link
Collaborator

@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70016

@cr-gpt
Copy link

cr-gpt bot commented Apr 26, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70023

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@cr-gpt
Copy link

cr-gpt bot commented Apr 26, 2023

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70031

All the data is reserved for two decimal places. When the gap of
current pr and master over five percent of the master, we will add ↑ or ↓.

Signed-off-by: Desiki-high <ding_yadong@foxmail.com>
@anolis-bot
Copy link
Collaborator

@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/70032

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@Desiki-high , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@Desiki-high Desiki-high requested a review from imeoer April 26, 2023 05:05
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit 944cc69 into dragonflyoss:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make benchmark compare summary more clear
3 participants