-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder: split out builder into a dedicated crate #1321
Conversation
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78692 |
@jiangliu , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78693 |
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 45.67% 45.68%
=======================================
Files 123 123
Lines 37254 37255 +1
Branches 37254 37255 +1
=======================================
+ Hits 17017 17020 +3
+ Misses 19338 19337 -1
+ Partials 899 898 -1
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
Why is this a breaking change :) |
This PR introduces new crates, so existing code may fail to compile, so marked as "breaking changes". |
builder/Cargo.toml
Outdated
#assert_matches = "1.5.0" | ||
|
||
[features] | ||
#fusedev = ["fuse-backend-rs/fusedev"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to keep it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be removed:)
Split out builder into a dedicate nydus-builder crate, to reduce dependencies of the nydus-rafs crate. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/78716 |
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
@@ -0,0 +1,50 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file specially added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The builder has a ut case, which uses this file, though it's ignored currently.
#[ignore]
#[test]
fn test_build_stargz_toc() {
let tmp_dir = vmm_sys_util::tempdir::TempDir::new().unwrap();
let tmp_dir = tmp_dir.as_path().to_path_buf();
let root_dir = &std::env::var("CARGO_MANIFEST_DIR").expect("$CARGO_MANIFEST_DIR");
let source_path =
PathBuf::from(root_dir).join("../tests/texture/stargz/estargz_sample.json");
Split out builder into a dedicate nydus-builder crate, to reduce dependencies of the nydus-rafs crate.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.