Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: add nydusd hot upgrade test case #1603

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Jul 18, 2024

Relevant Issue (if applicable)

  • smoke: add nydusd hot upgrade test case
  • smoke: refactor nydusd methods for testing

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer requested a review from a team as a code owner July 18, 2024 10:55
@imeoer imeoer requested review from bergwolf, hsiangkao and power-more and removed request for a team July 18, 2024 10:55
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (32b6ead) to head (717999e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1603      +/-   ##
==========================================
- Coverage   61.43%   61.42%   -0.01%     
==========================================
  Files         145      145              
  Lines       48032    48032              
  Branches    46007    46007              
==========================================
- Hits        29510    29506       -4     
- Misses      16963    16964       +1     
- Partials     1559     1562       +3     

see 3 files with indirect coverage changes

@imeoer imeoer force-pushed the improve-smoke branch 4 times, most recently from 8fdc621 to 630b66d Compare July 19, 2024 02:13
Renaming and adding some methods for nydusd struct, for easily controlling
nydusd process.

And support SKIP_CASES env to allow skipping some cases.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
The test case in hot_upgrade_test.go is different with takeover_test.go,
it not depend on snapshotter component.

Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Copy link
Member

@Desiki-high Desiki-high left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit a6bd8cc into dragonflyoss:master Jul 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants