Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiline replacements #25

Closed
2 of 3 tasks
drahnr opened this issue Jun 15, 2020 · 1 comment
Closed
2 of 3 tasks

multiline replacements #25

drahnr opened this issue Jun 15, 2020 · 1 comment
Assignees
@drahnr
Labels
enhancement 🦚 New feature or request help wanted 🤝 Extra attention is needed internal ⚙️ Internal issues or TODOs
Milestone
v0.3.0

Comments

@drahnr
Copy link
Owner

drahnr commented Jun 15, 2020 •
edited
Loading

Currently there are quite a few places where single line issues are assumed, which is not necessarily true for grammar errors.

Required changes:

  • fmt::Display for Suggestion must handle multiple spans, multiline spans and therefor fragmented ranges
  • avoid Range types, use Span instead
  • create complex cases
@drahnr drahnr added enhancement 🦚 New feature or request help wanted 🤝 Extra attention is needed internal ⚙️ Internal issues or TODOs heavy-duty 🚜 Big features not easy to implement labels Jun 15, 2020
@drahnr
Copy link
Owner Author

drahnr commented Jun 22, 2020

Should be simplified a lot once CheckableChunk of #55 is merged

@drahnr drahnr removed the heavy-duty 🚜 Big features not easy to implement label Jul 8, 2020
This was referenced Jul 10, 2020
Closed
Closed
drahnr added a commit that referenced this issue Jul 10, 2020
@drahnr
docs/README: add link to multiline replacements to issue #25
6d686cc
@drahnr drahnr mentioned this issue Jul 10, 2020
Closed
3 tasks
@drahnr drahnr added this to the v0.4.0 milestone Jul 14, 2020
@drahnr drahnr self-assigned this Jul 16, 2020
@drahnr drahnr modified the milestones: v0.4.0, v0.3.0 Jul 16, 2020
drahnr added a commit that referenced this issue Jul 16, 2020
@drahnr
fix/commonmark: allow common mark input
e535f38 
To fully function, requres impl of #25 to not assert.

Closes #14
drahnr added a commit that referenced this issue Jul 16, 2020
@drahnr
feat/multiline: initial handling of multiline literals
1e548ab 
Ref #25
drahnr added a commit that referenced this issue Jul 17, 2020
@drahnr
fix/multiline: span and chunk as well as tests are no multiline ready
9d0ee93 
Ref #25
drahnr added a commit that referenced this issue Jul 17, 2020
@drahnr
fix/multiline: span, chunk, and tests are now multiline ready
01aefc2 
Ref #25
drahnr added a commit that referenced this issue Jul 17, 2020
@drahnr
fix/multiline: span, chunk, and tests are now multiline ready
b8012a3 
Ref #25
@drahnr drahnr mentioned this issue Jul 17, 2020
Closed
drahnr added a commit that referenced this issue Jul 23, 2020
@drahnr
fix/commonmark: allow common mark input
765f0c7 
To fully function, requres impl of #25 to not assert.

Closes #14
drahnr added a commit that referenced this issue Jul 23, 2020
@drahnr
feat/multiline: initial handling of multiline literals
600b857 
Ref #25
drahnr added a commit that referenced this issue Jul 23, 2020
@drahnr
fix/multiline: span, chunk, and tests are now multiline ready
b64c8f1 
Ref #25
drahnr added a commit that referenced this issue Jul 24, 2020
@drahnr
fix/suggestion: rework the offset calculation for the relevant line
7788a35 
Closes #68
Closes #42
Ref #25
drahnr added a commit that referenced this issue Jul 27, 2020
@drahnr
fix/suggestion: rework the offset calculation for the relevant line
ca492ee 
Closes #68
Closes #42
Ref #25
@drahnr drahnr closed this as completed Jul 27, 2020
drahnr added a commit that referenced this issue Aug 19, 2020
@drahnr
fix/commonmark: allow common mark input
3b7ec2b 
To fully function, requres impl of #25 to not assert.

Closes #14
@drahnr drahnr mentioned this issue Nov 10, 2020
Closed
@drahnr drahnr mentioned this issue Feb 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drahnr drahnr

Labels
enhancement 🦚 New feature or request help wanted 🤝 Extra attention is needed internal ⚙️ Internal issues or TODOs
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@drahnr