Updates the check for the IBM CR pull secret #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces check for specific `default-icr-io` name with a pattern match Addresses draios#110
seansund
force-pushed
the
ibmcloud-secret-fix
branch
from
61231ce
to
cba7791
Compare
| SECRET_NAME=$(echo ${default_secret} | sed "s/default-/$NAMESPACE-/g") | ||
|
|
||
| echo "Processing ${default_secret} as ${SECRET_NAME}" | ||
| kubectl get secret ${default_secret} -n default -o yaml --export | sed "s/name: default-/name: $NAMESPACE-/g" | kubectl -n $NAMESPACE apply -f - |
There was a problem hiding this comment.
the --export option is reporting that's been deprecated - can we use something else with this logic ?
There was a problem hiding this comment.
The --export can be removed; the previous code was doing the kubectl get secret ... | kubectl apply ... without the --export. However, I've seen "Mutating Webhook" issues on OpenShift 4.3 at times without it.
bennythejudge
approved these changes
Apr 30, 2020
mbreitung
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default-icr-ioname with a pattern matchAddresses #110