Return complete string tokens in eventformatter #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
reviewed
Jan 22, 2018
| @@ -151,8 +154,7 @@ void sinsp_evt_formatter::set_format(const string& fmt) | |||
| if(last_nontoken_str_start != j) | |||
| { | |||
| sinsp_filter_check * chk = new rawstring_check(lfmt.substr(last_nontoken_str_start, j - last_nontoken_str_start)); | |||
| m_tokens.push_back(chk); | |||
| m_chks_to_free.push_back(chk); | |||
| m_tokens.emplace_back(make_pair("", chk)); | |||
There was a problem hiding this comment.
Do you need to add chk to m_chks_to_free ?
There was a problem hiding this comment.
Nice catch, I didn't meant to delete that line!
mattpag
force-pushed
the
export-complete-token
branch
from
226c8d9
to
2d2043d
Compare
mstemm
approved these changes
Jan 22, 2018
luca3m
approved these changes
Feb 1, 2018
Directly use the string token to retrieve the filtercheck used in the format string instead of just using the filtercheck field info. This way indexes/arguments will be present inside the key.
mattpag
force-pushed
the
export-complete-token
branch
from
2d2043d
to
32a3e61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly use the string token to get the complete filtercheck in the format string instead of just using the filtercheck field info.
This way indexes/arguments will be reported too (e.g.
proc.aname[2]instead of onlyproc.aname)