Support glob matching on strings. #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me |
|
Looks cool, but is this going to break Windows? |
|
Oh right, it will. fnmatch is POSIX only. Is it acceptable to throw an error saying glob is not supported on windows, or should I add an equivalent? |
|
I'd say the most important thing is to make sure sysdig still compiles, you can judge the effort required for adding the portable code, I don't think it's that important. |
|
Ok, I added a general function that calls fnmatch on unix and PathMatchSpec on windows. I still need to test the windows build but I'll do that tomorrow. |
Committing separate from other changes.
mstemm
force-pushed
the
glob-filenames
branch
from
c8f6e03
to
30a3209
Compare
Windows has min()/max() macros that conflict with the functions from numeric_limits::min()/max(), so disable them via #define NOMINMAX.
mstemm
force-pushed
the
glob-filenames
branch
from
30a3209
to
73cdebe
Compare
Add new comparison "glob" that allows for glob matching on pathnames. The glob matching is handled by a utils function glob_match that calls fnmatch on windows and PathMatchSpec on windows. This handles simple stuff like *, ?, etc. but not shell specific extensions.
mstemm
force-pushed
the
glob-filenames
branch
from
723ad23
to
122afdc
Compare
luca3m
pushed a commit
that referenced
this pull request
Oct 10, 2016
* Whitespace diffs. Committing separate from other changes. * Fix windows build. Windows has min()/max() macros that conflict with the functions from numeric_limits::min()/max(), so disable them via #define NOMINMAX. * Support glob matching on strings. Add new comparison "glob" that allows for glob matching on pathnames. The glob matching is handled by a utils function glob_match that calls fnmatch on windows and PathMatchSpec on windows. This handles simple stuff like *, ?, etc. but not shell specific extensions.
dmyerscough
pushed a commit
to dmyerscough/sysdig
that referenced
this pull request
Mar 3, 2017
* Whitespace diffs. Committing separate from other changes. * Fix windows build. Windows has min()/max() macros that conflict with the functions from numeric_limits::min()/max(), so disable them via #define NOMINMAX. * Support glob matching on strings. Add new comparison "glob" that allows for glob matching on pathnames. The glob matching is handled by a utils function glob_match that calls fnmatch on windows and PathMatchSpec on windows. This handles simple stuff like *, ?, etc. but not shell specific extensions.
This was referenced Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new comparison "glob" that allows for glob matching on pathnames, as
implemented by fnmatch(). This handles simple stuff like *, ?, etc. but
not shell specific extensions.
Sound like a good idea @luca, @ldegio @gianlucaborello?