Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish API implementation separately into Pip #2

Open
apbarratt opened this issue Jun 10, 2022 · 1 comment
Open

Publish API implementation separately into Pip #2

apbarratt opened this issue Jun 10, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@apbarratt
Copy link
Contributor

Your API implementation is clean and easy to read.

Could we perhaps publish it as a separate git repo on git hub and link it up with pip some how? That way someone could just run pip install socoPy and then have a simple import socoPy to utilise it :)

It would allow for a one stop shop for all python implementations to use a single wrapper of the API and for a community of open source folk to fork and submit PRs to it when API changes should be needed without everyone having to implement changes themselves :)

@apbarratt apbarratt changed the title Public API implementation separately into Pip Publish API implementation separately into Pip Jun 10, 2022
@drakhart
Copy link
Owner

Hi Andy! Thanks for your feedback, really appreciated.

You're right, that'd be ideal, and as you might have guessed that's why I coded the Super Soco API to be as "clean and easy to read" as possible: I do plan on publishing it on pypi before this integration reaches its first stable version.

To be honest I didn't do it before only because I was still hoping for Vmoto Super Soco to reply to my request and give their thumbs up to publishing all this, API client included, but it's already been months so I don't think that will ever happen. Now I just hope I don't ever receive a thumbs down either.

So yeah, tl;dr: rest assured that I will eventually publish the Super Soco API client separately on pypi, and also look into either publishing or potentially using existing API clients for OpenStreetMaps and Open Topo Data.

@drakhart drakhart added the enhancement New feature or request label Jun 10, 2022
@drakhart drakhart added this to the 1.0.0 (stable) milestone Jun 10, 2022
@drakhart drakhart self-assigned this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants