When CTRL is pressed always ask #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a functionality that overrides preselected mode to "ask" when CTRL is pressed while entering fullscreen.
|
I was looking for exactly this. Thank you for taking the time to develop this and hope this is merged in future releases. |
|
This is in the latest version released on Chrome! |
Unfortunately this doesn't seem to be working on Youtube at least in my testing now on Version 32. Selecting fullscreen as a default works however shift+click or ctrl+click on the fullscreen button on the player does not trigger the popup asking which fullscreen method to use. |
|
OOo very stupid! I forgot about fullscreen 😂 (I disable the extension more when you have fullscreen selected, in hopes that I break less websites... but that is going out I guess!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality that overrides preselected mode to "ask" when CTRL is pressed while entering fullscreen.
The popup shows info when it becomes applicable.
Readme was updated to reference this new functionality.
Ngl, javascript isn't my language of choice, async/awaits are completely unknown to me so I wasn't able to utilize them (I don't even know if I should have). I understand if the code isn't on par with the rest of the codebase, but this is the best I can do. That said, all works fine on my end so hopefully, I did not introduce any problems.