Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send metrics even if the node is not in the default network #1008

Closed
mcamou opened this issue May 18, 2022 · 0 comments · Fixed by #1017
Closed

Send metrics even if the node is not in the default network #1008

mcamou opened this issue May 18, 2022 · 0 comments · Fixed by #1017
Assignees
@mcamou
Labels
monitoring Area: Monitoring
Milestone
Ceremony dashboard

Comments

@mcamou
Copy link
Contributor

mcamou commented May 18, 2022

This came up because pl3-rpc.testnet.drand.sh did not join the default network on 2022-05-04. It would seem that, if the node is not in the default network, https://github.com/drand/drand/blob/master/metrics/metrics.go#L404 errors out with {"metrics": "failed to get peer handlers", "err": "no group yet"}
@mcamou mcamou added the monitoring Area: Monitoring label May 18, 2022
@mcamou mcamou added this to the Ceremony dashboard milestone May 18, 2022
@mcamou mcamou self-assigned this May 31, 2022
mcamou added a commit that referenced this issue May 31, 2022
@mcamou
Send metrics over GRPC even if the node is not in the default netwo…
c733293 
…rk (closes #1008)
@mcamou mcamou linked a pull request May 31, 2022 that will close this issue
Send metrics over GRPC even if the node is not in the default network (#1008) #1017
Merged
mcamou added a commit that referenced this issue Jun 1, 2022
@mcamou
Send metrics over GRPC even if the node is not in the default netwo…
d7018aa 
…rk (closes #1008)
mcamou added a commit that referenced this issue Jun 6, 2022
@mcamou
Send metrics over GRPC even if the node is not in the default netwo…
f9a81de 
…rk (#1008) (#1017)

* Send metrics over GRPC even if the node is not in the `default` network (closes #1008)

* Change handlerForPeer comment to be more explicit

* Another comment edit

* Happy linters, happy code

* PR comments

* A bit of cleanup

* Make some test failure messages a bit more explicit

* Quite a bit of refactoring

* Linter happiness

* PR comments

* Increase metrics test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcamou mcamou

Labels
monitoring Area: Monitoring
Projects
None yet
Milestone
Ceremony dashboard
Development

Successfully merging a pull request may close this issue.

Send metrics over GRPC even if the node is not in the default network (#1008) drand/drand
1 participant
@mcamou