New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly close all clients in tests #655

Merged

willscott merged 2 commits into master from testclientclose

Jul 8, 2020

Member

willscott commented Jul 7, 2020

No description provided.


          explicitly close all clients in tests

65a18aa

alanshaw approved these changes

View reviewed changes


          Merge branch 'master' into testclientclose

1f024c5

github-actions bot commented Jul 8, 2020

⚠️ This PR appears to introduce incompatibility

Resharing to a node running this version failed

- Node 127.0.0.3:37503 has different cokey than 127.0.0.1:36563

willscott merged commit e467d06 into master

willscott deleted the testclientclose branch

July 8, 2020 15:01

willscott added a commit that referenced this pull request


          explicitly close all clients in tests (#655)

2ae1625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet