allow struct tag, add test #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe https://github.com/muir/reflectutils/blob/main/unpack.go#L59 is worth exploring. |
I was looking for something like this when writing auto conversions. I don't think there is a strong need now 🤷🏻♂️ (Especially now that you added tags which seems are not supported there?) |
dranikpg
reviewed
Nov 28, 2023
|
tags are supported in that package
that said, it's up to you. go source code reimplements what you have many
times, so maybe it is okay. (referencing encoding/json and sql.Scan)
…On Tue, Nov 28, 2023, 4:45 AM Vladislav ***@***.***> wrote:
maybe https://github.com/muir/reflectutils/blob/main/unpack.go#L59 is
worth exploring.
I was looking for something like this when writing auto conversions. I
don't think there is a strong need now 🤷🏻♂️ (Especially now that you
added tags which seems are not supported there?)
—
Reply to this email directly, view it on GitHub
<#13 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARH66OVC3SD4NWTXC5HLJ3YGW6GJAVCNFSM6AAAAAA75QBDFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGU3DCOJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dranikpg
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows the usage of gtrs:"x" struct tag