Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drape - New life for Draper #742

Closed
akodkod opened this issue May 29, 2016 · 16 comments
Closed

Drape - New life for Draper #742

akodkod opened this issue May 29, 2016 · 16 comments

Comments

@akodkod
Copy link
Collaborator

akodkod commented May 29, 2016

Hello,

I'm sorry for advertising. I'm doing this not for PR, I'm doing this for help the people.
I think the fact that this gem is no longer supported, it is a big problem for all of us.

That is why I decided to create Drape - the adapted version of Draper for Ruby on Rails 5 with some fixes.

I would be very grateful for any support and development.

Best Regards,
Andrew

@seanlinsley
Copy link
Member

@MrEmelianenko I recently gained commit access to Draper specifically in order to get it working with Rails 5. Would you be interested in merging your changes into Draper, and becoming a maintainer?

@akodkod
Copy link
Collaborator Author

akodkod commented May 29, 2016

@seanlinsley Yes, It would be great. But It will be little difficult, because I'm do not fork the Draper repository, just create new one. Also I removed some outdated code for Rails 3, we need merge it very carefully.

@akodkod
Copy link
Collaborator Author

akodkod commented May 30, 2016

@seanlinsley What's the next steps? If you want I can prepare the PR at this week.

@md5
Copy link

md5 commented Jun 2, 2016

@seanlinsley You may want to take a look at the comments for #681 where there is some discussion about collecting Rails 5-related fixes.

@md5
Copy link

md5 commented Jun 2, 2016

There's also #712 and probably others

@akodkod
Copy link
Collaborator Author

akodkod commented Jun 6, 2016

@md5 Thank you for your comments! I have already checked it when I created my version of Draper for Rails 5.

@shaneog
Copy link

shaneog commented Jul 4, 2016

Hi @seanlinsley - since you have committer access now, do you recommend to use @MrEmelianenko's Drape or wait for a new Draper release?

@seanlinsley
Copy link
Member

I would suggest continuing to use Draper.

@shaneog
Copy link

shaneog commented Jul 4, 2016

Great! Do you need any help in preparing a Rails 5 release, and if not, do you have an idea when one would be ready?
Thank you for your work!

@pavelbulanov
Copy link

See work on rails-5 branch is happening now in the real time. Thanks @seanlinsley

@seanlinsley
Copy link
Member

I just opened a PR with my changes: #752. There are still a few things to do, but the tests are passing. Please review the changes and try the branch out in your app.

@seanlinsley
Copy link
Member

@MrEmelianenko are there things from Drape that you would like to see in Draper? Feel free to create PRs for them!

#752 should now be complete. Once I get Rubygems access from @steveklabnik I'll create a release candidate.

@seanlinsley
Copy link
Member

3.0.0.pre1 has been released. Please give it a test and open tickets for any issues found.

I'm going to go ahead and close this ticket. @MrEmelianenko I'd be happy to add you as a Draper maintainer 😄

@akodkod
Copy link
Collaborator Author

akodkod commented Jul 10, 2016

@seanlinsley It would be great, I think together we can make a lot of great things for Draper.

@seanlinsley
Copy link
Member

I just invited you :octocat:

@McRip
Copy link
Contributor

McRip commented Oct 25, 2016

@MrEmelianenko, @seanlinsley: Is anybody of you still working on Draper or Drape?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants