fix: Don't delegate public methods overridden by a private in the decorator

[brunohkbx]

Public methods defined on the object was being delegated to the decorator even though it was overridden by a private method.

Testing

1. Create a simple PORO with a public method

class Job
  def location
    Struct.new(:id) { }
  end
end

1. Create a decorator and override the public method with a private

class JobDecorator < Draper::Decorator
  delegate_all

  private

  def location
    LocationDecorator.new(object.location)
  end
end

3. It should raise an exception when calling .location from the decorator

[9] pry(main)> JobDecorator.decorate(Job.new).location
NoMethodError: private method `location' called for #<JobDecorator:0x0000559f113ba118>

References

• Issue Name clash with private methods #771

[codebycliff]

Looks good. I left to nitpicky suggestions on style / formatting, but other than that, it's good to go. I wonder how breaking of a change this should be considered.

[codebycliff]

Thanks for all your contributions lately, they have been greatly appreciated!

[brunohkbx]

@codebycliff I was thinking the same. Could it be a breaking change? 🤔
What if we raise a deprecated warning instead of raising an error?

[codebycliff]

@brunohkbx I think that's definitely an option. I'm also considering just bumping the major version when I release this. It's been a while since a major version has been released, so I don't think it would be that big of a deal.

[springerigor]

@brunohkbx & @codebycliff I need your attention #875. Thanks in advance 🙂