chore: Add documentation of restricting permissions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail because the installation of the latest dmm release still needs access to raw.githubusercontent. Should i remove this bit from the ci? as it doesn't reflect PR's but just shows installing dmm works. Otherwise, it would show our ci fails, but the ci would pass after a new release |
|
looks like this branch needs to be updated before being merged |
|
btw, im pushing the docs related to this issue to staging |
|
Np, i'll probs leave it (merging) until #62 is merged cause theres gonna be more conflicts |
This was referenced Sep 15, 2020
Merged
ebebbington
added
the
Type: Chore
ebebbington
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Description
Update docs to use more restrictions when using permissions
Use current logic and cdn.deno.land to get latest std release. The reason for this was we don't have to add 'raw.githubusercontent' into the
--allow-netpermission. Plus, the cdn provides the latest std version so the logic was pretty just pointless extra codeOther Notes