Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for nest.land modules #77

Merged
merged 6 commits into from
Oct 24, 2020
Merged

feat: Added support for nest.land modules #77

merged 6 commits into from
Oct 24, 2020

Conversation

mjrlowe
Copy link
Contributor

@mjrlowe mjrlowe commented Oct 24, 2020

Fixes #31.

Description

These changes allow the user to update and check x.nest.land dependencies (including std ones) using dmm, in the same way that deno.land/x modules are currently handled.

Other Notes

  • dmm info still only looks for deno.land modules - it could be nice for it to look for a nest.land package as well.
  • I changed the module interface a little so that denoLandURL is now moduleURL and githubURL is now repositoryURL, so that it isn't as deno.land/x specific.

@mjrlowe
Copy link
Contributor Author

mjrlowe commented Oct 24, 2020

Oh, I need to update the readme too...

@ebebbington
Copy link
Member

Hye @thewizardbear really nice work!! :D I don't suppose 1 or tests could be added for the check command? Just to ensure that works when it checks a dep that is a nest import eg dmm check cliffy

@ebebbington ebebbington mentioned this pull request Oct 24, 2020
Merged
@mjrlowe
Copy link
Contributor Author

mjrlowe commented Oct 24, 2020

Done.

ebebbington
ebebbington approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@ebebbington ebebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was quick, nice one xD LGTM :) Definitely a worthy PR for nest hacktoberfest :) I'll add the label too - really good job

@ebebbington ebebbington changed the title Added support for nest.land modules feat: Added support for nest.land modules Oct 24, 2020
@ebebbington ebebbington added hacktoberfest-approved Type: Minor Merging this pull request results in a minor version increment labels Oct 24, 2020
@ebebbington ebebbington merged commit 66e4d5b into drashland:master Oct 24, 2020
@mjrlowe
Copy link
Contributor Author

mjrlowe commented Oct 24, 2020

Thanks :)

@mjrlowe
Copy link
Contributor Author

mjrlowe commented Oct 25, 2020

Hi, I think the label should be hacktoberfest-accepted. Would you be able to change it?

@ebebbington
Copy link
Member

@thewizardbear sure, all done, by mad!

@mjrlowe
Copy link
Contributor Author

mjrlowe commented Oct 26, 2020

Sorry to be a pain but you managed to misspell hacktoberfest this time. 🙃

@ebebbington ebebbington added hacktoberfest-accepted hacktoberfest ! and removed hacktoberfest-accepted hacktoberfest ! labels Oct 26, 2020
@ebebbington
Copy link
Member

For crying out loud! xD There we go, and it's no problem :P

@crookse crookse mentioned this pull request Nov 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebebbington ebebbington ebebbington approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted hacktoberfest ! Type: Minor Merging this pull request results in a minor version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Nest.Land as a Registry
2 participants
@mjrlowe @ebebbington