-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow services to run at startup #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think there will also be problems with #getRequest
, because that method uses this
, but inside deno's listen API, this
will refer to the function as our server class is no longer in the scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs needed for website too i assume?
@ebebbington , yea docs are needed |
…ke services more flexible in the future
…allow server to run services at startup time; add server.addResource() that services can leverage
52de2e7
to
04af103
Compare
Summary
interfaces.ts
andtypes.ts
runAtStartup
to service interfaceServer.addResource()
.T
prefix from types. I don't know why I started doing this, but they're obviously types because they come from thetypes.ts
file. woooooOoOopz.Service
class (kind of like how we're doing it for the error handler -- we expect an interface, not a class)