Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow services to end lifecycle #619

Merged
merged 9 commits into from
Mar 22, 2022
Merged

feat: Allow services to end lifecycle #619

merged 9 commits into from
Mar 22, 2022

Conversation

ebebbington
Copy link
Member

@ebebbington ebebbington commented Mar 12, 2022 •
edited by crookse

Closes #605

@ebebbington ebebbington linked an issue Mar 12, 2022 that may be closed by this pull request
Allow services to send repsonses and end lifecycle #605
Closed
@ebebbington
Copy link
Member Author 

server before
v
resource exists
v
class before
v
method exists
v
method before
v
call resource method
v
method after
v
class after
v
server after

If one of those steps fail, the link is broken and response is immediantly returned

@crookse crookse added the Type: Minor Merging this pull request results in a minor version increment label Mar 19, 2022
crookse
crookse reviewed Mar 19, 2022
View reviewed changes
Copy link
Member

@crookse crookse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. instead of marking a bunch of comments, i made a PR related to the comments i would've made: #621

crookse and others added 2 commits March 21, 2022 21:49
@crookse
Merge pull request #621 from drashland/service-send-consolidation
ac8adf8 
refactor: add respond() function to consolidate returning responses in request handler
@crookse
chore: deno fmt; fix comment
c4c6f3a
@crookse crookse merged commit e343ffd into main Mar 22, 2022
@crookse crookse deleted the service-send branch March 22, 2022 02:03
@crookse crookse mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crookse crookse crookse left review comments

@Guergeiro Guergeiro Awaiting requested review from Guergeiro

Assignees
No one assigned
Labels
Type: Minor Merging this pull request results in a minor version increment
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow services to send repsonses and end lifecycle
2 participants
@ebebbington @crookse