Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks #3

Closed
ebebbington opened this issue Jun 19, 2020 · 0 comments · Fixed by #10
Closed

Hooks #3

ebebbington opened this issue Jun 19, 2020 · 0 comments · Fixed by #10
Assignees
@ebebbington

Comments

@ebebbington
Copy link
Member

ebebbington commented Jun 19, 2020 •
edited
Loading

What

Develop the following hooks:

  • Rhum.beforeAll
  • Rhum.beforeEach
  • Rhum.afterAll
  • Rhum.afterEach
  • Rhum.before?
  • Rhum.after?

All methods should be public

Why
This is a testing framework dammit!

Checklist

  • Update README where needed

  • Unit & integration tests

Resources

Use the following issue as a guideline if possible

Pseudo-code for Implementation

Nothing to provide as of yet
@ebebbington ebebbington self-assigned this Jun 21, 2020
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Clean up and added logic for running hooks
52cece5
@ebebbington ebebbington mentioned this issue Jun 21, 2020
Merged
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Believed to have gotten hooks working
b780f7f
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Update README
e8a0d2b
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Added integration test for before each hooks
7f9f1f0
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Added integration test for before all hook
fc76d85
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Added integration test for after each hook
f0d478a
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Added integration test for after all hook
413117e
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Corrected example tests following Rhum.run() addition
0040c58
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Cleanup
e3abb5c
ebebbington pushed a commit that referenced this issue Jun 21, 2020
[issue-#3-hooks] Fixed unit tests
157a028
ebebbington pushed a commit that referenced this issue Jun 22, 2020
[issue-#3-hooks] Fixed tests
c11a979
ebebbington pushed a commit that referenced this issue Jun 22, 2020
Merge branch 'master' into issue-#3-hooks-tests-fixes
0a3d5da
crookse added a commit that referenced this issue Jun 22, 2020
@crookse
Merge branch 'master' into issue-#3-hooks
1427a35
crookse added a commit that referenced this issue Jun 22, 2020
@crookse
Merge branch 'issue-#3-hooks' into issue-#3-hooks-tests-fixes
d780dc5
crookse added a commit that referenced this issue Jun 22, 2020
@crookse
Merge branch 'issue-#3-hooks-tests-fixes' of https://github.com/drash…
9b88915 
…land/rhum into issue-#3-hooks-tests-fixes
ebebbington added a commit that referenced this issue Jun 22, 2020
@ebebbington
Merge pull request #13 from drashland/issue-#3-hooks-tests-fixes
d49ea1b 
Issue #3 hooks tests fixes
ebebbington added a commit that referenced this issue Jun 23, 2020
@ebebbington
Merge pull request #10 from drashland/issue-#3-hooks
bc68a57 
Issue #3 hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebebbington ebebbington

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #3 hooks drashland/rhum
1 participant
@ebebbington