-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Using normalized package architecture #21
Conversation
Why deleting all the |
Why is there an empty file |
|
||
```json5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why deleting this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a config.json.example
file people can directly copy and rename. Since the content is within the example file, it isn't much useful in the readme, i believe
Plus having a example file within the vars folder should avoid people to try creating a config.json at another locater, i hope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep it will be easier for some, but harder for a majority. People using this bot are in majority beginners, so we need to make this accessible. I'm just gonna adding it back, and we'll have both available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
drawbot/json_types.py
Outdated
@@ -1,9 +1,5 @@ | |||
from typing import Dict, Any, List, Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put this into the utils/
folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound fair enough, could move it when i'll be at home
This insure cogs to be a sub-package part of the whole drawbot package and thus being included in the installation process |
Yeah, but why leave it empty? |
There is nothing to really put in that init file since discord will use dynamic import for cogs. I believe that is more a design problem from the lib, as it would has been smarter to handle object, like the nextcord fork did, cause less "python weirdness" and a overall better code structure & logic. |
This pr changes the current code base to follow a standard python package architecture.
Main changes
vars
directory