Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom column type #106

Closed
wants to merge 1 commit into from
Closed

Custom column type #106

wants to merge 1 commit into from

Conversation

cazitouni
Copy link

Hello,

I've started to work on custom column types in order to solve #39.

I don't know if my approach would be good or if I forgot something, so the draft.

Let me know your opinion.
Regards, Clément.

Copy link

vercel bot commented May 14, 2024

@cazitouni is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@1ilit
Copy link
Member

1ilit commented May 18, 2024

Hi Clément! Thanks for the contribution,

A better way to handle this would be add the allowCreate attribute to <Select/> in TableField.jsx and handle the newly created type in toSQL.js appropriately.

Having a type 'CUSTOM' and then having to input the actual type in the values field for SETs and ENUMs isn't very intuitive.

@1ilit 1ilit closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants