Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis pr check #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

techgaun
Copy link
Contributor

based on the docs : https://docs.travis-ci.com/user/environment-variables/

TRAVIS_PULL_REQUEST: The pull request number if the current job is a pull request, “false” if it’s not a pull request.

This closes #199

@asmeurer
Copy link
Member

I think the test failure is relevant here.

@techgaun
Copy link
Contributor Author

oh crap I will check it out @asmeurer

@techgaun techgaun closed this Jun 21, 2017
@techgaun techgaun reopened this Jun 21, 2017
@techgaun
Copy link
Contributor Author

@asmeurer seems like this requires some more thought as I don't think

run(['git', 'checkout', get_travis_branch()])
would work. It would work for branch within the same repo but not on a different repo (like my fork for eg.). What do you suggest in this scenario?

@asmeurer
Copy link
Member

Hmm. It seems really that should be use the merge commit generated by Travis, not the original branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_travis_branch() giving wrong branch for PR
2 participants