Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch-whitelist logic #330

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Fix branch-whitelist logic #330

merged 2 commits into from
Nov 27, 2018

Conversation

asmeurer
Copy link
Member

When --branch-whitelist is passed with no arguments, (i.e., it's empty), it
should force the whitelist to be empty. Only when it is not passed at all
should it default to {master}.

I haven't tested this yet.

Should fix #329.

When --branch-whitelist is passed with no arguments, (i.e., it's empty), it
should force the whitelist to be empty. Only when it is not passed at all
should it default to {master}.

I haven't tested this yet.

Should fix #329.
@asmeurer
Copy link
Member Author

Looks like the conda cryptography module is broken in Python 3.6.

@asmeurer
Copy link
Member Author

Several old builds such as 1cecd14 were pushing from the empty --branch-whitelist build.

I pushed a commit to this branch that should force a deploy to verify that it doesn't do that anymore.

@asmeurer
Copy link
Member Author

Now it doesn't push https://travis-ci.org/drdoctr/doctr/jobs/460406133#L3272. You can also see the tag- directory wasn't updated on gh-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to restrict deploy on tags only
1 participant