Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ref-range): support formula #1126

Merged
merged 9 commits into from
Jan 13, 2024
Merged

feat(ref-range): support formula #1126

merged 9 commits into from
Jan 13, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Jan 12, 2024 •
edited
Loading

No description provided.

@Gggpound Gggpound self-assigned this Jan 12, 2024
@Gggpound Gggpound marked this pull request as draft January 12, 2024 12:28
@Gggpound Gggpound changed the title Feat ref range 0111 feat(ref-range): support formula Jan 13, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 13, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1792b0e) 29.96% compared to head (c5e1493) 29.98%.
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/sheets/src/services/ref-range/util.ts 96.15% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1126      +/-   ##
==========================================
+ Coverage   29.96%   29.98%   +0.02%     
==========================================
  Files         751      751              
  Lines       44440    44452      +12     
  Branches     9211     9206       -5     
==========================================
+ Hits        13317    13330      +13     
  Misses      27147    27147              
+ Partials     3976     3975       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@Gggpound Gggpound marked this pull request as ready for review January 13, 2024 03:32
@Gggpound Gggpound added the qa:untested This PR is ready to be tested label Jan 13, 2024
@Gggpound Gggpound merged commit 9feadfb into dev Jan 13, 2024
8 checks passed
@Gggpound Gggpound deleted the feat-ref-range-0111 branch January 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DR-Univer DR-Univer DR-Univer approved these changes

@Dushusir Dushusir Awaiting requested review from Dushusir Dushusir is a code owner

Assignees

@Gggpound Gggpound

Labels
qa:untested This PR is ready to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gggpound @DR-Univer @Dushusir