Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): insert row col with effect freeze #1464

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fix(sheet): insert row col with effect freeze #1464

merged 1 commit into from
Mar 5, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Mar 3, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1454

@yuhongz yuhongz changed the title fix: insert row col with effect freeze fix(sheet): insert row col with effect freeze Mar 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 31.51%. Comparing base (4cc9e3d) to head (ef9cba1).
Report is 4 commits behind head on dev.

Files Patch % Lines
...ges/sheets-ui/src/controllers/freeze.controller.ts 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1464      +/-   ##
==========================================
- Coverage   31.51%   31.51%   -0.01%     
==========================================
  Files         880      880              
  Lines       49364    49377      +13     
  Branches    10188    10192       +4     
==========================================
  Hits        15559    15559              
- Misses      33805    33818      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz added the qa:untested This PR is ready to be tested label Mar 4, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
wzhudev
wzhudev reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 8de2b10 into dev Mar 5, 2024
8 checks passed
@wzhudev wzhudev deleted the yuhongz/fix-insertrowcol-effect-freeze branch March 5, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Inserting rows or columns do not have an impact on the position of frozen rows and columns.
3 participants
@yuhongz @wzhudev @zhaolixin7