Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): worker error #1565

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix(formula): worker error #1565

merged 2 commits into from
Mar 13, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 13, 2024

  • I am sure that the code is update-to-date with the dev branch.

https://github.com/dream-num/univer-pro/issues/349

close #

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 13, 2024 06:23
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 13, 2024
Copy link

github-actions bot commented Mar 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 32.85%. Comparing base (5aeb65f) to head (ee254e7).

Files Patch % Lines
packages/engine-formula/src/basics/runtime.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1565      +/-   ##
==========================================
- Coverage   32.86%   32.85%   -0.01%     
==========================================
  Files         919      919              
  Lines       51202    51214      +12     
  Branches    10661    10663       +2     
==========================================
  Hits        16825    16825              
- Misses      34377    34389      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 47377ae into dev Mar 13, 2024
9 checks passed
@DR-Univer DR-Univer deleted the fix-formula-worker-apply branch March 13, 2024 06:37
ybzky pushed a commit that referenced this pull request Mar 19, 2024
* fix(formula): worker error

* fix(formula): merge interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants