Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheet): indirect support defined name #1899

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

DR-Univer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Apr 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 29.78%. Comparing base (496dcb8) to head (77a26c7).

Files Patch % Lines
...ine-formula/src/functions/lookup/indirect/index.ts 53.84% 6 Missing ⚠️
...ages/engine-formula/src/functions/base-function.ts 50.00% 4 Missing ⚠️
...ngine-formula/src/engine/ast-node/function-node.ts 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1899      +/-   ##
==========================================
+ Coverage   29.75%   29.78%   +0.02%     
==========================================
  Files        1172     1172              
  Lines       63936    63968      +32     
  Branches    13571    13578       +7     
==========================================
+ Hits        19026    19051      +25     
- Misses      44910    44917       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 6c0833a into dev Apr 15, 2024
8 checks passed
@DR-Univer DR-Univer deleted the feat-formula-indirect-defined-name branch April 15, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants