Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/log trace #59

Closed
wants to merge 2 commits into from
Closed

Feat/log trace #59

wants to merge 2 commits into from

Conversation

brownhash
Copy link
Contributor

@brownhash brownhash commented Mar 1, 2022 •
edited
Loading

Odin version(1.1.0-alpha)

Features

  • Generates a UUID and passes that to each backend request for log/request tracing
  • Echoes the UUID to the user for tracing

Resources

Example execution

➜  odin git:(feat/log_trace) go run main.go configure
Enter Backend Address: https://playground.d11dev.com
Enter Access Key: myaccesskey
(Secret) Enter Secret Access Key: 
[ INFO ] Request-Id: cf1f1dcd-8963-4e65-8acd-b89fc206082f

subhash-dream11
subhash-dream11 previously approved these changes Mar 1, 2022
View reviewed changes
brownhash
brownhash commented Mar 2, 2022
View reviewed changes
internal/backend/client.go
var uuid = uid.Uid()

// For user's reference to trace the execution
logger.Info("Request-Id: " + uuid)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chouguleds @subhash-dream11 Please confirm on this, if the request-id needs to be shown as an Info log or Debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or this can also be received from the Playground's response.

@brownhash brownhash added the do not merge Do not merge the marked PR label Mar 3, 2022
@chouguleds chouguleds removed their request for review August 25, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhash-dream11 subhash-dream11 subhash-dream11 left review comments

Assignees
No one assigned
Labels
do not merge Do not merge the marked PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brownhash @subhash-dream11 @BalkishanNanavath