Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile for issue #2 #10

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Makefile for issue #2 #10

merged 3 commits into from
Feb 15, 2021

Conversation

Flukas88
Copy link
Contributor

@Flukas88 Flukas88 commented Feb 15, 2021

Added a minimal Makefile even though Cmake would be a better tool

Luca Francesca added 2 commits February 15, 2021 08:53
Added simple makefile
Minor style refactors
@Flukas88 Flukas88 mentioned this pull request Feb 15, 2021
src/Makefile Outdated
.DEFAULT_GOAL := release

### Vars
APPLICATION := uwf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uwf??? 🗡️ :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plead the fifth

@dreamos82
Copy link
Owner

If i do just a make, it creates a relase-xyz empty folder, the compiled file stays in the same folder as the source.
Also (this is up to you more a general question) shouldn't be better to put the makefile in the main folder instead of src?

Should work better
@Flukas88
Copy link
Contributor Author

Flukas88 commented Feb 15, 2021

If i do just a make, it creates a relase-xyz empty folder, the compiled file stays in the same folder as the source.
Also (this is up to you more a general question) shouldn't be better to put the makefile in the main folder instead of src?

I forgot to put the folder prefix in the -o :)

As for the root folders, generally, you put it where your main() resides

@dreamos82 dreamos82 merged commit 3caf102 into dreamos82:master Feb 15, 2021
@dreamos82
Copy link
Owner

Looks good to me! 👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants