chore: scikit compatible version #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimox
force-pushed
the
chore/41-scikit-compatible
branch
from
005ed29
to
7b11ee1
Compare
Optimox
force-pushed
the
chore/41-scikit-compatible
branch
from
7b11ee1
to
de24412
Compare
eduardocarvp
reviewed
Dec 2, 2019
| Training and validation dataloaders | ||
| ------- | ||
| """ | ||
| raise NotImplementedError('users must define construct_loaders to use this base class') | ||
|
|
||
| def fit(self, X_train, y_train, X_valid=None, y_valid=None, |
There was a problem hiding this comment.
Shouldn't we call load_best_model at the end of this function? I'm not sure this is the best solution, but it can be misleading if the output model after the fit is completed is not the one that performs best on the validation set.
pytorch_tabnet/tab_model.py
Outdated
| lambda_sparse=1e-3, | ||
| clip_value=1, verbose=1, | ||
| lr=2e-2, optimizer_fn=torch.optim.Adam, | ||
| lr_params={}, scheduler=None, scheduler_fn=None, |
There was a problem hiding this comment.
Do we still have scheduler_params?
There was a problem hiding this comment.
disappeared by mistake I'm on it
Optimox
force-pushed
the
chore/41-scikit-compatible
branch
from
f87c275
to
b88ecf8
Compare
Optimox
force-pushed
the
chore/41-scikit-compatible
branch
from
b88ecf8
to
23682cd
Compare
Optimox
force-pushed
the
chore/41-scikit-compatible
branch
from
99a1099
to
f73983b
Compare
eduardocarvp
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
What kind of change does this PR introduce?
Make TabNet Scikit compatible!
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).closes #41