Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the suffix ":shared" of volume option of docker container #81

Open
junwha opened this issue Mar 27, 2023 · 4 comments
Open

About the suffix ":shared" of volume option of docker container #81

junwha opened this issue Mar 27, 2023 · 4 comments

Comments

@junwha
Copy link

junwha commented Mar 27, 2023

Hi, first I'm really appreciate for opening this amazing project as open source.

I'm trying to follow the instruction for building MOONRAY using docker container, but found weird section.

docker run -v /source/openmoonray/building/ubuntu22.04:/building:shared  -v /optix:/optix:shared --network=host --rm -it openmoonray_base

The documentation gets me to add the suffix :shared at the end of the volume directory, but it shows an error that "[My directory] is mounted on /home but it is not a shared mount".

As I know, it is sufficient to use -v /source/openmoonray/building:/building

Is there any special purpose for the :shared keyword?
I couldn't find any matching section from docker document.

Thank you.

@junwha junwha changed the title About the suffix of volume option of docker container About the suffix ":shared" of volume option of docker container Mar 27, 2023
@rgwilson68
Copy link
Contributor

There's no special purpose to :shared -- everything should work without this option

@junwha
Copy link
Author

junwha commented Mar 27, 2023

Then isn't it better to remove that keyword from the document? it makes the error

@vvzen
Copy link

vvzen commented Mar 27, 2023

I stumbled into this error too when trying #37 (comment), if it's not really needed, I'd vote for removing it too!

@junwha
Copy link
Author

junwha commented Mar 28, 2023

jlanz pushed a commit that referenced this issue Jul 29, 2024
Add the install_cgroup option to allow the installation of libcgroup to be selected.

Signed-off-by: Yoshiaki Senda <yoshiaki@live.it>
Co-authored-by: Yoshiaki Senda <yoshiaki@live.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants