Fixed perpetual loading state of add transaction view #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed no longer needed case of displaying loading indicator. Prior to the bills page work, it was planned to add an option to open a transaction edit view by providing the transaction id. This was removed, however one condition was left in, which prevented the view to initialize properly when the user wanted to create a new transaction.
|
oh whoops thanks. I only used the create from notification while testing and missed that. thanks for noticing and making a fix! |
dreautall
added a commit
that referenced
this pull request
Jul 20, 2024
Fixed perpetual loading state of add transaction view [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed no longer needed case of displaying loading indicator.
Prior to the bills page work, it was planned to add an option to open a transaction edit view by providing the transaction id. This was removed, however one condition was left in, which prevented the view to initialize properly when the user wanted to create a new transaction.