logout controller has a bug when destroying the session #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set up the post request to log out but running into problems with the implentation of the postLogout controller in authcontroller
postLogout: (req, res) => {
// console.log(req)
// res.send('hey back')
console.log('inside logout')
console.log('before logout - req.session:', req.session)
try{
req.logout(() => {
console.log('User has logged out')
console.log('after logout - req.session:', req.session)
}
}
right now i had to downgrade the passport package to 0.5.3 instead of most recent 0.7.0
when i tried to destroy the session on log out it would throw an error described by others here
https://stackoverflow.com/questions/50454992/req-session-destroy-and-passport-logout-arent-destroying-cookie-on-client-side
and here
jaredhanson/passport#907
i might be misunderstanding how logout works but i think i will move on to the next part because i believe users can log in and need to come back to the logout bug later