Implement "group 0" as a regular zigbee group #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and use that for group 0/All. - a group address of 0 actually works for Ikea and Osram lights, but not for Philips - finds a free group-address from 65520 downwards, 65535 does not work for Osram - add all lights when found after database load or after light search - remove all special cases and use "regular" groupcast
manup
reviewed
Jun 10, 2019
| group.setAddress(0); | ||
| group.setName("All"); | ||
| groups.push_back(group); | ||
| if (gwGroup0 == 0) { // get new id and replace old group0 and get new id |
There was a problem hiding this comment.
Please always use braces on the next line for if, for. So that the code base just has one code style.
if (gwGroup0)
{
}
There was a problem hiding this comment.
Thanks, missed this one, it's no my usual code style.
manup
reviewed
Jun 10, 2019
| if (!val.isEmpty()) | ||
| { | ||
| uint group0 = val.toUInt(&ok); | ||
| if (ok && (group0 <= 65535)) |
There was a problem hiding this comment.
Shouldn't 65535 be 0xFFF0 to align with the later code?
|
Thanks, I think this should work. For a later refactor we should consider to switch to a SQL table to map an REST-API group id and unqiueid to a Zigbee group id. |
|
Thanks @manup for reviewing. I'll update the PR tomorrow or the day after, or feel free to make those changes yourself. |
manup
added a commit
that referenced
this pull request
Jun 10, 2019
0 and larger than 0xfff7 is not valid for Osram Lightify. Related PR #1555
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly the first commit from #1471 so it can be reviewed and merged in stages. This:
-- just using Zigbee group id 0 did not work for all lights nor 65535, so it finds a free group from 65520 going downwards
-- removes all "group0" special cases
This should cause not change in behavior. On the Zigbee side each light will now have an extra group, and turning off or on all lights via group 0 on the api side is now achieved on the Zigbee side with a groupcast to this zigbee group instead of a broadcast.