Skip to content

🗼 collection of software development tips and principles

Notifications You must be signed in to change notification settings

drew2a/ivory-tower

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

10 Commits
 
 
 
 
 
 

Repository files navigation

Ivory Tower

🗼 collection of software development tips and principles

Principles of Design

“It is not enough for code to work.”

― Robert C. Martin

  1. DRY – Don’t Repeat Yourself
  2. KISS – Keep It Simple Stupid
  3. YAGNI – You Aren’t Gonna Need It
  4. SOLID:
    • S – Single Responsibility Principle
    • O – Open-Closed Principle
    • L – Liskov Substitution Principle
    • I – Interface Segregation Principle
    • D – Dependency Inversion Principle

Ref: SOLID in wikipedia

Ref: Summary of 'Clean code' by Robert C. Martin

Code Style

If you don't have your own guide, it's a good idea to adhere Google code style guides.

If you have your own guide, please keep it as general as possible.

Commit message

Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.

As is described at Documentation/SubmittingPatches in the Git repo

Alternative commit message notation

A specification for adding human and machine readable meaning to commit messages: https://www.conventionalcommits.org/en/v1.0.0/

TODO Comments

TODOs should include the string TODO in all caps, followed by the name, or other identifier of the person who can best provide context about the problem referenced by the TODO, in parentheses.

Example:

// TODO(drew2a) Add todo convention to CONTRIBUTING.md

Branching Model

Branch naming convention

  • Use slash to separate groups of branches
  • Use a ticket key in a branch name

Example

feature/123
feature/657-add-travis-ci

fix/741

release/1.2

PR

  • PR should improve overall code health of the system, even if the CL isn’t perfect
  • Instead of seeking perfection, what a reviewer should seek is continuous improvement
  • Review should be fast (1 day maximum)

More information: Pull Request

Bookmarks

About

🗼 collection of software development tips and principles

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published