Only test on older JDKs which are commonly LTS #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I'm reading this right Gradle 8.3 will support JDK 20 (and Kotlin 1.9 was merged last week). Maybe separate the test reductions and the JDK 20 bump into two PRs? |
|
Yeah, that's probably simplest. 20 can be used to run today, but you can't target 20 so you have to always have a lower target explicitly set. |
drewhamilton
approved these changes
Jul 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenJDK itself has no concept of LTS, so any vendor is welcome to deem any version an LTS version, but in general they all follow Oracle's lead with 8, 11, 17, and soon 21. These become a representative sample that covers the overwhelming majority of deployments, and thus should be sufficient for test coverage.
Closes #96